Split the prefix-cache-scorer plugins#323
Merged
github-actions[bot] merged 1 commit intollm-d:mainfrom Aug 31, 2025
Merged
Conversation
vMaroon
force-pushed
the
precise-prefix-cache
branch
2 times, most recently
from
3f37336 to
0ea8159
Compare
vMaroon
changed the title
precise-prefix-cache-scorer pluginprefix-cache-scorer plugins
vMaroon
force-pushed
the
precise-prefix-cache
branch
2 times, most recently
from
d427a3c to
7372bfb
Compare
Member
Author
|
The wasted time and the force-pushes are due to a typo that was fixed in the latest. |
- fixed typos install for `make lint` Signed-off-by: Maroon Ayoub <maroon.ayoub@ibm.com>
vMaroon
force-pushed
the
precise-prefix-cache
branch
from
7372bfb to
7e4ad00
Compare
Collaborator
|
/lgtm /approve |
github-actions
bot
added
the
lgtm
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
For a more intuitive UX, the llm-d precise-prefix-cache scorer plugin was unified with the IGW prefix-cache scorer. In a later work, a change in the IGW made it so that plugin names cannot be overridden, therefore this unification no longer works.
It is highly possible that given the precise-prefix-cache-aware scheduling well-lit path example, the unification no longer serves its purpose anyway (redundant).
Changes
prefix-cache-scorerpoints to the IGW's estimate scorerprecise-prefix-cache-scoreris what used to becache_trackingmodeRelates Issues
make lintdon't works in macOS #313FYI @Gregory-Pereira